[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26173: [PATCH 3/4] tests: ssh: Abstract session connection and authe
bug#26173: [PATCH 3/4] tests: ssh: Abstract session connection and authentication.
Tue, 21 Mar 2017 01:01:35 +0100
mu4e 0.9.18; emacs 25.2.1
Ludovic Courtès <address@hidden> writes:
> Clément Lassieur <address@hidden> skribis:
>> * gnu/tests/ssh.scm (run-ssh-test): Introduce make-session-for-test,
>> call-with-connected-session and call-with-connected-session/auth.
>> (run-ssh-test)["connect"]: Rename to "shell command". Abstract its session
>> connection and authentication work into the above three functions.
> It looks nicer with this change, cool!
>> - (match (connect! session)
>> - ('ok
>> - ;; Try the simple authentication methods. Dropbear
>> - ;; requires 'none' when there are no passwords, whereas
>> - ;; OpenSSH accepts 'password' with an empty password.
>> - (let loop ((methods (list (cut userauth-password! <> "")
>> - (cut userauth-none! <>))))
> This comment vanished in the refactoring but it might be worth keeping.
Oh! Sorry, that wasn't intentional.
> Otherwise LGTM, thanks!
bug#26173: [PATCH 2/4] services: openssh: Add 'subsystems' option., Clément Lassieur, 2017/03/19
bug#26173: [PATCH 3/4] tests: ssh: Abstract session connection and authentication., Clément Lassieur, 2017/03/19
bug#26173: [PATCH 1/4] services: openssh: Cosmetic changes., Ludovic Courtès, 2017/03/20