guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26500: [PATCH] gnu: Add mcomix.


From: nee
Subject: bug#26500: [PATCH] gnu: Add mcomix.
Date: Wed, 19 Apr 2017 00:09:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

Am 17.04.2017 um 21:21 schrieb Arun Isaac:
> 
> If mupdf is a heavy dependency and it is not commonly needed, you can
> drop it and just package with 7z and rar as dependencies.

I have successfully patched in the path for 7zip.
I init the variable that stores it with a unicode string. I make the
assumption that the store path will never contain a ' character.


I read a little bit about unrar and it's issues with mcomix.
Unrar is very old and only supports RAR2, as someone says in the mcomix
issues it is unable to unpack most rar archives created after 2002¹. On
other distro mcomix currently relies on an unfree rar package², and
there is an open ticket³ about switching to a free library like
libarchiver (which supports RAR5 and is also used by file-roller, which
works fine on GuixSD).

I tried unrar on the commandline and it would list file names, but
always fail on unpacking. When called by mcomix, it would always try to
read a password from stdin and freeze the gui.
I will omit rar support for now, since unrar is mostly useless.

> 
> Sort these inputs alphabetically, as I mentioned in the crawl thread.
> 
> LGTM, otherwise! Please send an updated patch. Thanks!
> 
Okay.

(1) https://sourceforge.net/p/mcomix/feature-requests/82/#2bc5
(2) https://sourceforge.net/p/mcomix/feature-requests/82/
(3) https://sourceforge.net/p/mcomix/feature-requests/85/

Attachment: 0001-gnu-Add-mcomix.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]