guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26924: [PATCH 07/12] gnu: calibre: Unbundle liberation fonts


From: Marius Bakke
Subject: bug#26924: [PATCH 07/12] gnu: calibre: Unbundle liberation fonts
Date: Mon, 15 May 2017 19:05:00 +0200
User-agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu)

Brendan Tildesley <address@hidden> writes:

> From 8840dc34801e3717831fce82fe525b7a36b15f2f Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <address@hidden>
> Date: Sun, 14 May 2017 16:36:13 +1000
> Subject: [PATCH 07/12] gnu: calibre: Unbundle liberation fonts
>
> *gnu/packages/ebook.scm (calibre): Delete liberation .ttf files
> [arguments]: Calibre still references the bundled fonts, so we install the
> packaged fonts to the directory the bundled fonts would have been.

This should mention the new [input], but I think it should also be a
[native-input] since it's just extracted and thrown away.

[...]

> @@ -144,7 +147,16 @@
>                (substitute* "setup/build_environment.py"
>                  (("sys.prefix") (string-append "'" pyqt "'")))
>                (setenv "PODOFO_INC_DIR" (string-append podofo 
> "/include/podofo"))
> -              (setenv "PODOFO_LIB_DIR" (string-append podofo "/lib"))))))))
> +              (setenv "PODOFO_LIB_DIR" (string-append podofo "/lib")))))
> +         (add-after 'install 'install-font-liberation
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (for-each (lambda (file)
> +                         (install-file file (string-append
> +                                             (assoc-ref outputs "out")
> +                                             
> "/share/calibre/fonts/liberation")))
> +                       (find-files (string-append
> +                                    (assoc-ref inputs "font-liberation")
> +                                    "/share/fonts/truetype"))))))))

Again, minor nitpicking: This phase should also end with a #t after
(for-each ...) since the return value is unspecified.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]