guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27327] [PATCH] bootloader: Add u-boot.


From: Ludovic Courtès
Subject: [bug#27327] [PATCH] bootloader: Add u-boot.
Date: Fri, 16 Jun 2017 10:40:39 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hello,

(+Cc: Mathieu.)

Danny Milosavljevic <address@hidden> skribis:

> * gnu/bootloader/u-boot.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi: Document it.

[...]

> +;;;
> +;;; Bootloader definitions.
> +;;;
> +
> +(define u-boot-bootloader
> +  (bootloader
> +   (inherit extlinux-bootloader)
> +   (name 'u-boot)
> +   (package #f)
> +   (installer #f)))

I still find it weird to use #f for these two fields.

I would find it more reasonable to have, say, a ‘make-u-boot-bootloader’
that returns a <bootloader> with all the fields appropriately set (not
#f).  Otherwise it sounds like we’re going to have to deal with support
requests #about “wrong type to apply: #f”, and I’d like to avoid that.
:-)

Can’t we just say that ‘package’ is always a <package> and that
‘installer’ is always a procedure?  Eventually we’ll hopefully arrange
to check that at macro-expansion time and/or via contracts.

WDYT?

Apart from that, pretty happy to see U-Boot finally making it into
GuixSD!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]