guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#27540] [PATCH] gnu: Add toxic.


From: Ludovic Courtès
Subject: [bug#27540] [PATCH] gnu: Add toxic.
Date: Sun, 02 Jul 2017 17:04:54 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Hi!

Theodoros Foradis <address@hidden> skribis:

> * gnu/packages/messaging.scm (toxic): New variable.

[...]

> +         (add-before 'build 'enable-python-scripting
> +           (lambda _
> +             (setenv "ENABLE_PYTHON" "1"))))))

Please return #t at the end of the phase, to explicitly denote success.

> +    (home-page "https://github.com/JFreegman/toxic";)
> +    (synopsis "Tox chat client using ncurses")
> +    (description "@code{toxic} is a Tox-based instant messenging client
> +which formerly resided in the Tox core repository,and is now available
> +as a standalone application.")

One minor request: could the description focus on the functionality
(“console-based instant messaging program that does this and that”)
rather than on its history?  That should be more helpful to users
looking for a Tox client.

Apart from that it LGTM.  Could you send an updated patch?

Thank you!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]