[bug#27657] [PATCH 3/3] gnu: wayland: Add workaround for graphviz 2.40.1.

[Arun Isaac]

Marius Bakke writes:

> Arun Isaac <address@hidden> writes:
>
>> * gnu/packages/freedesktop.scm (wayland)[arguments]: Add fix-graphviz phase.
>
> Thanks!

Oops! I just got this mail, and have already pushed this patch to
staging. I'll have to make these changes a separate commit. Sorry about
the communication gap.

> [...]
>
>> +       (modify-phases %standard-phases
>> +         ;; Remove record shapes to workaround graphviz 2.40.1 problems
>> +         ;; 
>> http://www.graphviz.org/content/i-havent-been-able-render-these-files-graphviz-226
>> +         ;; This will likely be fixed upstream in the next release
>
> Please add punctuations here. Why is it likely fixed next release, is
> there a patch or bug report upstream? If so, please add them here.

I thought it will likely be fixed next release because of the following
thread:
https://lists.freedesktop.org/archives/wayland-devel/2017-June/034218.html

I'll replace this sentence with another one saying that this is a known
upstream bug.

>
>> +         (add-before 'build 'fix-graphviz
>> +           (lambda _
>> +             (substitute* "doc/doxygen/dot/x-architecture.gv"
>> +               (("Mrecord") "none")))))))
>
> And make sure this phase ends on #t.

Will do. I keep forgetting to return #t from phases. Can't Guix error
out if #t is not returned from the phase?