guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#28384] [PATCH] gnu: Fix build failures caused by commit.


From: Kei Kebreau
Subject: [bug#28384] [PATCH] gnu: Fix build failures caused by commit.
Date: Fri, 08 Sep 2017 12:41:49 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Hi Kei,
>
> The subject is truncated.  :-)  Caused by which commit?
>
> Kei Kebreau <address@hidden> skribis:
>
>> * gnu/packages/bioinformatics.scm (seek)[arguments]: Modify unpack phase.
>> * gnu/packages/ci.scm (cuirass)[arguments]: Add patch-/bin/sh phase.
>
> This is weird, normally the ‘patch-source-shebangs’ phase, which happens
> right before ‘configure’, should take care of these, no?
>

Normally the 'patch-source-shebangs' does just that, but in this case
the script needs to be patched because the bootstrapping phase depends
on perl.

>> diff --git a/gnu/packages/ci.scm b/gnu/packages/ci.scm
>> index c449754be..3b182b826 100644
>> --- a/gnu/packages/ci.scm
>> +++ b/gnu/packages/ci.scm
>> @@ -216,7 +216,11 @@ their dependencies.")
>>                 (substitute* "Makefile.am"
>>                   (("tests/repo.scm \\\\") "\\"))
>>                 #t))
>> -           (add-after 'disable-repo-tests 'bootstrap
>> +           (add-after 'disable-repo-tests 'patch-/bin/sh
>> +             (lambda _
>> +               (substitute* "build-aux/git-version-gen"
>> +                 (("#!/bin/sh") (string-append "#!" (which "sh"))))))
>
> This phase should return #t.

Thanks for catching that.

>
> Thanks,
> Ludo’.

Attachment: 0001-gnu-Use-modify-phases-syntax.patch
Description: Text document

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]