[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29099] [PATCH] gnu: Add kodi-cli.
From: |
Oleg Pykhalov |
Subject: |
[bug#29099] [PATCH] gnu: Add kodi-cli. |
Date: |
Fri, 03 Nov 2017 06:57:05 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marius Bakke <address@hidden> writes:
[...]
>> Maybe call this item of the feature list as
>> “Send text to the Kodi keyboard”?
>
> "Send text to the Kodi keyboard" is much better, thanks!
>
>> + (arguments
>> + `(#:modules ((guix build utils))
>> + #:builder
>> + (begin
>> + (use-modules (guix build utils))
>> + (copy-recursively (assoc-ref %build-inputs "source") ".")
>> + (substitute* "kodi-cli"
>> + (("/bin/bash") (string-append (assoc-ref %build-inputs "bash")
>> + "/bin/bash"))
>> + (("output=\\$\\((curl)" all curl)
>> + (string-append "output=$("
>> + (assoc-ref %build-inputs "curl")
>> + "/bin/" curl))
>> + (("play_youtube `(mpsyt)" all mpsyt)
>> + (string-append "play_youtube `"
>> + (assoc-ref %build-inputs "mps-youtube")
>> + "/bin/" mpsyt)))
>
> FYI, you could also use (which "curl") etc from (guix build utils) here,
> but I usually prefer this form.
Thanks for notice. I prefer a form used in attached patch, too.
>> address@hidden
>> address@hidden Play, pause, stop the current playing item.
>> address@hidden Skip forward or backward in the current playing item.
>
> These should be "currently playing".
Done.
>> address@hidden Play or queue to the current list YouTube videos.
>
> "... current list of YouTube videos."
>
> (note the "of")
Done.
> LGTM otherwise. Don't forget to add a copyright line for yourself.
OK. I think it's fine to merge it now.
Pushed as 72df48dbad95c3bc70a2962f496420ce3363d0de
Oleg,
Thanks.
signature.asc
Description: PGP signature