[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29386: Update taglib to 1.11.1.
From: |
Marius Bakke |
Subject: |
bug#29386: Update taglib to 1.11.1. |
Date: |
Tue, 21 Nov 2017 22:25:30 +0100 |
User-agent: |
Notmuch/0.25.2 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) |
Pierre Langlois <address@hidden> writes:
> Hello Guix!
>
> This is a patch to update taglib. I've had to enable building as a
> shared library otherwise gst-plugins-good would fail to link. Also,
> `guix lint' warned about the home page redirecting to http://taglib.org
> so I thought I'd fix that too.
Hello Pierre,
Thank you for this patch, and for checking dependent packages! I've
applied it after fixing a typo in the commit message (home page).
> Finally, I tried to enable the tests by adding "-DBUILD_TESTS" as a
> configure flag but they are explicitely disabled if building the shared
> library:
> ~~~
> if(BUILD_TESTS AND NOT BUILD_SHARED_LIBS)
> enable_testing()
> add_subdirectory(tests)
> endif()
> ~~~
>
> Oh well, how does this look?
OK! Perhaps we could do a separate build just for the tests, but that
should be in a standalone patch anyway.
Pushed as d1451fa0d0b27a20ef3a1b3fe8d53a995f0c4d85.
signature.asc
Description: PGP signature