[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29432: [PATCH] gnu: diffoscope: Fix error messages related to compar
|
From: |
Kei Kebreau |
|
Subject: |
bug#29432: [PATCH] gnu: diffoscope: Fix error messages related to comparison tools. |
|
Date: |
Sat, 25 Nov 2017 16:20:05 -0500 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Leo Famulari <address@hidden> writes:
> On Sat, Nov 25, 2017 at 12:51:52PM -0500, Kei Kebreau wrote:
>> Leo Famulari <address@hidden> writes:
>>
>> > On Fri, Nov 24, 2017 at 04:09:58PM -0500, Kei Kebreau wrote:
>> >> * gnu/packages/package-management.scm (diffoscope)[arguments]: Replace
>> >> readelf
>> >> substitution and add stat and getfacl substitutions.
>> >> [inputs]: Add acl.
>> >
>> > Can you add an example of the error messages in the commit message?
>> > Otherwise LGTM.
>> >
>>
>> Like this?
>>
>> Errors fixed include the following:
>> "FileNotFoundError: [Errno 2] No such file or directory: 'readelf'"
>> "diffoscope.comparators.directory: Unable to find 'getfacl', some
>> directory metadata differences might not be noticed."
>> "diffoscope.comparators.directory: Unable to find 'stat'"
>
> Sure!
Pushed to master as 2af6be91d59ad5aefe01e90aa9045e26d8667098. Thank you
for the review!
signature.asc
Description: PGP signature