[bug#29875] [PATCH] gnu: qemu: Add wrapper for Samba.

[Ludovic Courtès]

Hello!

Marius Bakke <address@hidden> skribis:

> Rutger Helling <address@hidden> writes:

[...]

>> +         ;; Create a wrapper for Samba. This allows QEMU to use Samba 
>> without
>> +         ;; pulling it in as an input. Note that you need to explicitly 
>> install
>> +         ;; Samba in your Guix profile for Samba support.
>> +         (add-after 'install-info 'create-samba-wrapper
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (let* ((out    (assoc-ref %outputs "out"))
>> +                    (libexec (string-append out "/libexec")))
>> +               (system* "touch" "samba-wrapper")
>> +               (call-with-output-file "samba-wrapper"
>> +                 (lambda (port)
>> +                   (format port "#!/bin/sh
>> + exec smbd $@")))
>> +               (chmod "samba-wrapper" #o755)
>> +               (install-file "samba-wrapper" libexec))
>> +             #t))

Why not patch qemu to use exec*p instead of exec* so that ‘smbd’ is
searched for in $PATH?

The wrapper does the job, but it looks more complex to me than this
initial suggestion.

Ludo’.