[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30701] [PATCH 3/4] tests: databases: Add a system test for PostgreS
[bug#30701] [PATCH 3/4] tests: databases: Add a system test for PostgreSQL.
Mon, 05 Mar 2018 01:32:32 +0100
mu4e 1.0; emacs 25.3.1
Christopher Baines <address@hidden> writes:
> * gnu/tests/databases.scm (%postgresql-os, %test-postgresql): New variables.
> (run-postgresql-test): New procedure.
> gnu/tests/databases.scm | 59
> 1 file changed, 59 insertions(+)
> + (test-assert "service running"
> + (marionette-eval
> + '(begin
> + (use-modules (gnu services herd))
> + (match (start-service 'postgres)
> + (#f #f)
> + (('service response-parts ...)
> + (match (assq-ref response-parts 'running)
> + ((pid) (number? pid))))))
> + marionette))
I don't understand the point of the PID check here. pg_ctl will ensure
that the daemon has started (by checking its PID), so I don't think
there is any need to redo its work. I guess the PID you'll get here is
the one of pg_ctl, which is probably not what you want.
I believe that (start-service 'postgres) returning true means pg_ctl
succeeded in its check that the daemon is running. So this is probably
(test-assert "service running"
(use-modules (gnu services herd))
[bug#30701] [PATCH 1/4] services: Rework the PostgreSQL config file to use a record type., Clément Lassieur, 2018/03/04