[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31036] [PATCH] gnu: Add Emacs dumb-jump

From: Arun Isaac
Subject: [bug#31036] [PATCH] gnu: Add Emacs dumb-jump
Date: Tue, 03 Apr 2018 23:04:29 +0530

Thank you for contributing to Guix! The following are some changes.

> +;; the version needs to have a v in it because of how the github releases 
> are maintained.
> +(define-public emacs-dumb-jump
> +(package
> +  (name "emacs-dumb-jump")
> +  (version "v0.5.2")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +            "";
> +             version ".tar.gz"))

We normally include the "v" in the source URI itself, not in the
version. So, you'd end up with the following uri.

(string-append ""; version 

> +  (synopsis
> +    "Jump to definition for multiple languages without configuration")
> +  (description
> +    "Dumb Jump is an Emacs \"jump to definition\" package with support for
> +multiple programming languages that favors \"just working\" over speed or
> +accuracy.  This means minimal -- and ideally zero -- configuration with
> +absolutely no stored indexes (TAGS) or persistent background processes.  Dumb

Downcase TAGS to tags.

> +Jump performs best with The Silver Searcher `ag` or ripgrep `rg` installed.

Please put ag and rg within @command{} -- @command{ag} and @command{rg}.

This package appears to have tests. Could you add a check phase for
running them?

Also, the first line of the commit message should read

gnu: Add emacs-dumb-jump.


gnu: Add Emacs dumb-jump.

Could you send an updated patch?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]