[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31277] [PATCH 3/3] services: cgit: Make project-list permit a strin
[bug#31277] [PATCH 3/3] services: cgit: Make project-list permit a string.
Sat, 28 Apr 2018 12:57:16 +0200
mu4e 1.0; emacs 25.3.1
Christopher Baines <address@hidden> writes:
> Instead of having the service manage the list, it's useful to be able to point
> this at an existing file, for example, when using cgit together with gitolite.
> * gnu/services/cgit.scm (project-list?): New procedure.
> (serialize-project-list): Handle string values.
> (<cgit-configuration>): Change the predicate for project-list to allow lists
> and strings.
Good idea! But could you replace 'string?' with 'file-object?', so that
the file can be in the store?
And could you update the documentation? There is a helper
(generate-cgit-documentation) that might help you do it.
Otherwise it looks good to me. Thank you!