guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4 instead of


From: Ricardo Wurmus
Subject: [bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary.
Date: Thu, 24 May 2018 11:22:22 +0200
User-agent: mu4e 1.0; emacs 25.3.1

Hi Alex,

> This patch set will cause javacc to bootstrap from javacc-4 instead of
> the bundled bootstrap jar. The next step would be to figure out how to
> bootstrap javacc-4 by hand, which would be challenging I think...

Thanks for this.

The patches look fine to me.

>         (modify-phases %standard-phases
> -         (add-after 'unpack 'delete-bundled-libs
> +         (add-after 'unpack 'delete-bundled-jars
>             (lambda _
> -             (delete-file-recursively "lib") #t))
> -         (replace 'install (install-jars "target")))))))
> +             (delete-file-recursively "bootstrap")
> +             (delete-file-recursively "lib")
> +             #t))

Can we delete these things in a snippet instead?

(I vaguely remember that we didn’t use snippets for jars because
patch-and-repack wouldn’t support the jar format, but I don’t know if
that’s still the case.)

-- 
Ricardo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]