[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32094] [PATCH] git: Call 'url-cache-directory' outside 'update-cach
From: |
Oleg Pykhalov |
Subject: |
[bug#32094] [PATCH] git: Call 'url-cache-directory' outside 'update-cached-checkout' body. |
Date: |
Tue, 10 Jul 2018 06:39:22 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello Ludovic,
Thank you for review.
address@hidden (Ludovic Courtès) writes:
> Oleg Pykhalov <address@hidden> skribis:
>
>> * guix/git.scm (update-cached-checkout): Call 'url-cache-directory' in
>> 'cache-directory' key argument.
>
> ‘latest-repository-commit’ would need to be adjusted accordingly.
>
> Could you do that and make sure ‘guix pull’ still behaves the same as
> before?
When I adjusted ‘latest-repository-commit’ I thought about removing
‘url-cache-directory’ call from ‘update-cached-checkout’ instead of
moving ‘url-cache-directory’ call to ‘cache-directory’ argument.
I'm not sure it's possible to call ‘url-cache-directory’ in argument of
‘update-cached-checkout’, because ‘url-cache-directory’ requires ‘url’
argument which itself is the argument of ‘update-cached-checkout’.
(define* (url-cache-directory url
#:optional (cache-directory
(%repository-cache-directory)))
…)
(define* (update-cached-checkout url
#:key
(ref '(branch . "origin/master"))
(cache-directory
(%repository-cache-directory)))
…)
Here is an updated patch which was successfully tested with ‘guix pull’.
0001-git-Call-url-cache-directory-outside-update-cached-c.patch
Description: [PATCH] git: Call 'url-cache-directory' outside
signature.asc
Description: PGP signature