[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#32186] [PATCH] gnu: Add emacs-rust-mode.
From: |
Kei Kebreau |
Subject: |
[bug#32186] [PATCH] gnu: Add emacs-rust-mode. |
Date: |
Tue, 17 Jul 2018 10:30:22 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello Rouby,
> * gnu/packages/emacs.scm: New variable.
> ---
> gnu/packages/emacs.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index c6c7a1df4..68780aea8 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -11410,3 +11410,33 @@ siblings and friends. This visual overview can also
> be used to browse your
> entries. You can think of entries as nodes in a mind map, or pages in a
> wiki.")
> (license license:expat)))
> +
> +(define-public emacs-rust-mode
> + (let ((commit "64b4a2450e4d4c47f6307851c9b2598cd2254d68")
> + (revision "0"))
> + (package
> + (name "emacs-rust-mode")
> + (version (git-version "0.3.0" revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/rust-lang/rust-mode")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0pbz36lljgb7bdgx3h3g0pq1nss1kvn8mhk1l3mknsmynd6w4nd8"))))
I'm guessing that you chose this snapshot because of the additional bug
fixes? If so, please include that information in a comment.
> + (build-system emacs-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (replace 'check
> + (lambda _
> + (invoke "sh" "run_rust_emacs_tests.sh"))))))
> + (home-page "https://github.com/rust-lang/rust-mode")
> + (synopsis "Major Emacs mode for editing Rust source code")
> + (description
> + "This package provide major Emacs mode for editing Rust source code.")
Here I would change "provide" to "provides a", as it reads more naturally.
> + (license (list license:expat
> + license:asl2.0)))))
Also, don't forget to add a copyright line at the top of
gnu/packages/emacs.scm for yourself! Other than those small things, this
patch looks and works fine. Could you send an updated patch?
signature.asc
Description: PGP signature