|
From: | Tobias Geerinckx-Rice |
Subject: | bug#32055: [PATCH 0/2] Add sqlcrush. |
Date: | Wed, 22 Aug 2018 00:53:56 +0200 |
Ludo', This got buried after the holdays. Thanks for the review! Ludovic Courtès wrote:
Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:
[...]
+ (propagated-inputs + `(("python-cryptography" ,python-cryptography) + ("python-psycopg2" ,python-psycopg2) + ("python-pymysql" ,python-pymysql) + ("python-sqlalchemy" ,python-sqlalchemy)))
[...]
If it’s an application rather than a library, then perhaps we don’t needto propagate these?
Agreed.
+ (synopsis "Pure-Python MySQL Driver")Nitpick: "driver" (lowercase). Otherwise LGTM, thanks!
Pushed with the suggested changes as 311f06c et al. Kind regards, T G-R
[Prev in Thread] | Current Thread | [Next in Thread] |