[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33265] [WIP RFC v4] services: Add file system monitoring service.
From: |
Ludovic Courtès |
Subject: |
[bug#33265] [WIP RFC v4] services: Add file system monitoring service. |
Date: |
Sat, 10 Nov 2018 23:19:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello!
Danny Milosavljevic <address@hidden> skribis:
> * gnu/services/monitoring.scm (file-system-monitoring-configuration): New
> variable.
> (file-system-monitoring-entry): New variable.
> (file-system-monitoring-service-type): New variable.
> * gnu/tests/monitoring.scm (%test-file-system-monitoring): New variable.
> * doc/guix.texi (File System Monitoring Service): New subsubsection.
Nice! Should we call it ‘fswatch-monitoring-service’, since there may
be other tools to achieve similar results?
> address@hidden file system monitoring
> address@hidden File System Monitoring Service
> +
> +The @code{(gnu services monitoring)} module provides a shepherd service to
s/shepherd/Shepherd/
> address@hidden {Scheme Variable} file-system-monitoring-service-type
> +The service type for @command{fswatch}, which provides the file system
> +monitoring capability.
Perhaps add a @uref to the fswatch home page.
> address@hidden
> +(service file-system-monitoring-service-type
> + (file-system-monitoring-configuration
> + (monitored-files '("/foo/bar"))
> + (handlers '((lambda args
> + (display "UH OH\n"))))))
It would seem more natural to me for ‘handlers’ to be singular,
‘handler’. Also I’d use a gexp there (though in this particular example
it doesn’t make any difference):
(file-system-monitoring-configuration
(monitored-files '("/foo/bar"))
(handler #~(lambda (file whatever)
(format #t "~a modified!~%" file))))
> + (start #~(let ((handlers
> + (list #$@(map file-system-monitoring-entry-handler
> + monitored-files))))
> + (lambda ()
> + (sleep 1)
> + (for-each (lambda (handler)
> + (handler))
> + handlers)
> + (fork+exec-command
> + `(#$(file-append package "/bin/fswatch")
> + "--one-event"
> + "-l" "1" ; latency: 1 s
> + ; "-d"
> + "--"
> + #$@(if monitored-files
> + (map file-system-monitoring-entry-file-name
> + monitored-files)
> + '("/does_not_exist")))))))
The ‘sleep’ call looks suspicious. :-)
IIUC, the service stops (and is respawned) every time an even occurs, is
that right?
Can’t we instead remove ‘--one-event’ and pass fswatch a script to run?
In that case, we’d pass it something along these lines:
#$(scheme-file "event-handler.scm"
#~(for-each (lambda (handler) …) …))
WDYT?
> +(define file-system-monitoring-service-type
> + (service-type (name 'monitor-file-system)
> + (extensions
> + (list (service-extension shepherd-root-service-type
> +
> file-system-monitoring-shepherd-services)))
> + (compose concatenate)
> + (extend (lambda (config monitored-entries)
> + (let ((monitored-files
> + (map file-system-monitoring-entry-file-name
> + monitored-entries))
> + (handlers
> + (map file-system-monitoring-entry-handler
> + monitored-entries)))
So here if we changes ‘handlers’ to ‘handler’, we could do:
(apply compose (map file-system-monitoring-entry-handler entries))
Thanks,
Ludo’.
- [bug#33265] [WIP RFC] services: Add file system monitor service., Danny Milosavljevic, 2018/11/04
- [bug#33265] [WIP RFC v2] services: Add file system monitor service., Danny Milosavljevic, 2018/11/04
- [bug#33265] [WIP RFC v3] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/04
- [bug#33265] [WIP RFC v3] services: Add file system monitoring service., swedebugia, 2018/11/05
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/05
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service.,
Ludovic Courtès <=
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/10
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/10
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Ludovic Courtès, 2018/11/11
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/11
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Danny Milosavljevic, 2018/11/11
- [bug#33265] [WIP RFC v4] services: Add file system monitoring service., Ludovic Courtès, 2018/11/11
[bug#33265] [WIP RFC] services: Add file system monitor service., Clément Lassieur, 2018/11/05