[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorte
From: |
Ludovic Courtès |
Subject: |
[bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. |
Date: |
Mon, 03 Dec 2018 14:31:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello,
Arun Isaac <address@hidden> skribis:
> * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure.
> (%checkers): Add it.
> ---
> guix/scripts/lint.scm | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
> index 2314f3b28..37e8a1ec5 100644
> --- a/guix/scripts/lint.scm
> +++ b/guix/scripts/lint.scm
> @@ -8,6 +8,7 @@
> ;;; Copyright © 2017 Alex Kost <address@hidden>
> ;;; Copyright © 2017 Tobias Geerinckx-Rice <address@hidden>
> ;;; Copyright © 2017 Efraim Flashner <address@hidden>
> +;;; Copyright © 2018 Arun Isaac <address@hidden>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -301,6 +302,22 @@ of a package, and INPUT-NAMES, a list of package
> specifications such as
> (package-input-intersection (package-direct-inputs package)
> input-names))))
>
> +(define (check-inputs-should-be-sorted package)
> + ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE
> + ;; are not lexicographically ordered.
It’s something we rarely do so we’d get warnings for most packages. As
a side effect, people may pay less attention to what ‘guix lint’ says.
As for the goal itself, I think sorting is a good idea when there are
lots of inputs (things like IceCat), but otherwise I personally don’t
think it matters that much.
What do people think?
Thanks,
Ludo’.