[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33801: import: github: Support source URIs that redirect to GitHub

From: Ludovic Courtès
Subject: bug#33801: import: github: Support source URIs that redirect to GitHub
Date: Wed, 09 Jan 2019 15:11:16 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hello Arun,

Arun Isaac <address@hidden> skribis:

>> Perhaps we should add a test to catch this specific case so that it
>> doesn’t pop up again?
> Yes, we should. But, there is a problem. "make check
> TESTS=tests/lint.scm" fails with the following error message even on
> master.
> make[4]: *** [Makefile:4920: tests/lint.log] Error 1
> make[4]: Leaving directory '/home/foo/guix'
> make[3]: *** [Makefile:4902: check-TESTS] Error 2
> make[3]: Leaving directory '/home/foo/guix'
> make[2]: *** [Makefile:5145: check-am] Error 2
> make[2]: Leaving directory '/home/foo/guix'
> make[1]: *** [Makefile:4679: check-recursive] Error 1
> make[1]: Leaving directory '/home/foo/guix'
> make: *** [Makefile:5147: check] Error 2
> On examining tests/lint.log, I find the following error message.
> gnu/packages/lisp.scm:3806:7: In procedure inputs:
> error: xclip: unbound variable
> But, this makes no sense to me. Any idea what's happening?

Ouch.  This is fixed by 804b9b18ac9188ffb6c6891cbb9241c6a80ed7c8.  I
think we were just lucky it didn’t bite before.

> Should I immediately push the patch I sent in the last mail, and then
> deal with this problem separately? Without that patch, the linter is
> faulty and might annoy people.

You can recheck your patch and push it I guess.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]