[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33902: [PATCH] gnu: Add wlstream.
From: |
Rutger Helling |
Subject: |
bug#33902: [PATCH] gnu: Add wlstream. |
Date: |
Thu, 10 Jan 2019 08:57:16 +0100 |
Thanks for the review, pushed with fixed indentation.
I'll make sure to double check with ./etc/indent-code.el from now on.
On Wed, 09 Jan 2019 16:41:31 +0100
Ludovic Courtès <address@hidden> wrote:
> Hello Rutger,
>
> Rutger Helling <address@hidden> skribis:
>
> > From b38bdecd0dee379f50241092aab2be4b69606209 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <address@hidden>
> > Date: Fri, 28 Dec 2018 20:15:22 +0100
> > Subject: [PATCH 1/2] gnu: ffmpeg: Add libdrm support.
> >
> > * gnu/packages/video.scm (ffmpeg): Add libdrm support.
>
> [...]
>
> > From 5d18a851060605deee53c275159a6d37bfc0b007 Mon Sep 17 00:00:00
> > 2001 From: Rutger Helling <address@hidden>
> > Date: Sat, 29 Dec 2018 16:17:59 +0100
> > Subject: [PATCH 2/2] gnu: Add wlstream.
> >
> > * gnu/packages/video.scm (wlstream): New variable.
>
> Both LGTM!
>
> > +(define-public wlstream
> > + (let ((commit "182076a94562b128c3a97ecc53cc68905ea86838")
> > + (revision "1"))
> > + (package
> > + (name "wlstream")
> ^
>
> We usually add an extra space here. Did you try running
> ./etc/indent-code.el on your packages? Or is it too inconvenient?
>
> Thanks,
> Ludo’.
pgpJmtUR4A1td.pgp
Description: OpenPGP digital signature