[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34034] [PATCH]: Add Bochs

From: Leo Famulari
Subject: [bug#34034] [PATCH]: Add Bochs
Date: Thu, 10 Jan 2019 18:42:28 -0500
User-agent: Mutt/1.11.0 (2018-11-25)

On Thu, Jan 10, 2019 at 07:18:04PM +0100, Guy fleury wrote:
> From 0380fab2ad7195407fc29afb830a86dbfae03b3f Mon Sep 17 00:00:00 2001
> From: guy fleury iteriteka <address@hidden>
> Date: Thu, 10 Jan 2019 17:33:30 +0100
> Subject: [PATCH] gnu: Add Bochs

Thank you!

> +    (outputs '("out"))

This is the default, so it's okay to leave it out.

> +     `(#:tests? #f)) ;; no tests exits

"No tests exist"

> +    (inputs
> +     `(("glib" ,glib)
> +       ("gtk+" ,gtk+)
> +       ("libxrandr" ,libxrandr)))

I noticed that it doesn't keep references to glib and gtk+:

$  guix gc --references $(./pre-inst-env guix build --no-grafts bochs)

So, I think it's possible to omit those two inputs.

> +     "Bochs is an emulator which can emulate Intel x86 CPU, common I/O
> +devices, and a custom BIOS.  It can also compiled to emulate many different

"It can also be compiled to ..."

> +Bochs can running most Operating Systems inside the emulation including 
> Linux,
> +DOS or Microsoft Windows.")

"Bochs can run most operating systems ..."

> +    (license license:lgpl2.0)))

I checked some of the source files and I think it is lgpl2.0+.

Can you send an updated patch? :)

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]