[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34198] [PATCH 2/2] gnu: Add diffpdf.
From: |
Ricardo Wurmus |
Subject: |
[bug#34198] [PATCH 2/2] gnu: Add diffpdf. |
Date: |
Tue, 29 Jan 2019 18:08:45 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi Danny,
> * gnu/packages/pdf.scm (diffpdf): New variable.
[…]
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-paths
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "diffpdf.pro"
> + (("-lpoppler-qt4")
> + (string-append "-L" (assoc-ref inputs "poppler-qt4")
> + "/lib -lpoppler-qt4"))
Is this really necessary? Shouldn’t it be enough to have this directory
on LIBRARY_PATH at build time?
> + (inputs
> + `(("poppler-qt4" ,poppler-qt4) ; at least 0.20.1
> + ("qt-4" ,qt-4)))
I was hoping we could get rid of Qt 4 in the near future, because it
doesn’t get security fixes. Is there no Qt 5 variant?
> + (home-page "http://www.qtrac.eu/diffpdf-foss.html")
> + (synopsis "Compare two PDF files")
> + (description "This package provides a GUI tool to compare two PDF
> files.")
> + (license license:gpl2)))
Looks like GPLv2 or later.
--
Ricardo