guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34217] [PATCH 01/11] gnu: Add ruby-cucumber-wire.


From: Björn Höfling
Subject: [bug#34217] [PATCH 01/11] gnu: Add ruby-cucumber-wire.
Date: Sun, 3 Feb 2019 22:03:39 +0100

On Sun, 27 Jan 2019 11:49:46 +0000
Christopher Baines <address@hidden> wrote:

> Package version 0.0.1 initially, as this is what's needed by Cucumber
> 3, and Cucumber 4 hasn't been released yet.

I would prefer to see this hint as a comment in the code, not in the
commit message: When I as a developer stumble upon the package
definition and see it is outdated, I would just update it and not
search all commit messages to find out it shouldn't. A comment near the
package definition or version would prevent that mistake.

Otherwise, LGTM.

Thanks,

Björn





reply via email to

[Prev in Thread] Current Thread [Next in Thread]