[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34240: [PATCH 4/5] gnu: Add system-config-printer.
From: |
Christopher Baines |
Subject: |
bug#34240: [PATCH 4/5] gnu: Add system-config-printer. |
Date: |
Wed, 13 Feb 2019 08:21:04 +0000 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Ricardo Wurmus <address@hidden> writes:
> Christopher Baines <address@hidden> writes:
>
>> * gnu/packages/gnome.scm (system-config-printer): New variable.
> […]
>> + (arguments
>> + `(#:imported-modules ((guix build python-build-system)
>> + ,@%glib-or-gtk-build-system-modules)
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'patch-Makefile.am
>> + (lambda _
>> + ;; The Makefile generates some scripts, so set a valid shebang
>> + (substitute* "Makefile.am"
>> + (("/bin/bash") (which "bash")))
>> + #t))
> […]
>> + (add-before 'configure 'bootstrap
>> + (lambda _
>> + ;; Run ./bootstrap as otherwise the build fails with
>> + ;; automake-1.15: command not found
>> + (invoke "./bootstrap")
>> + #t))
>
> The build system already provides a “bootstrap” phase, so maybe it would
> be better to delete “configure” in “patch-Makefile.am” to activate the
> bootstrap phase.
>
> Otherwise looks good to me. Thanks!
Great, I've made that change to the system-config-printer phases and
pushed these patches now.
Thanks,
Chris
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#34240: [PATCH 4/5] gnu: Add system-config-printer.,
Christopher Baines <=