[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34246: [PATCH 0/3] Improve the upower-service style.
From: |
Christopher Baines |
Subject: |
bug#34246: [PATCH 0/3] Improve the upower-service style. |
Date: |
Sat, 16 Feb 2019 22:15:43 +0000 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Ludovic Courtès <address@hidden> writes:
> Hello!
>
> Christopher Baines <address@hidden> skribis:
>
>> These patches update the style of the upower-service. Improving and
>> documenting the <upower-configuration> record, and deprecating the
>> upower-service procedure.
>>
>> Directly using record types as default values for service types, along
>> with default values for the fields in the record type is generally more
>> flexible and configurable than using procedures for service
>> configuration. It means that the configuration for the service can be
>> changed programatically by generating new configuration based off of the
>> original configuration, rather than having to rerun the procedure that
>> created the configuration in the first place.
>>
>>
>> Christopher Baines (3):
>> services: Improve the upower-configuration record.
>> services: Improve the upower-service-type.
>> services: desktop: Deprecate the upower-service procedure.
>
> All three patches LGTM. Thanks for taking the time to do this! :-)
Great, I've pushed these patches to master now :)
signature.asc
Description: PGP signature