[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34948: [PATCH 3/3] system: Add 'essential-services' field to <operat
From: |
Ludovic Courtès |
Subject: |
bug#34948: [PATCH 3/3] system: Add 'essential-services' field to <operating-system>. |
Date: |
Tue, 26 Mar 2019 00:02:31 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi Arun!
Arun Isaac <address@hidden> skribis:
> This neatly gets rid of all the #:container? arguments. That's very
> nice! :-) I haven't actually built and tested these patches, but these
> LGTM. Just one minor observation below.
>
>> + (cons (service system-service-type
>> + (let ((locale (operating-system-locale-directory os)))
>> + (with-monad %store-monad
>> + (return `(("locale" ,locale))))))
>> + (append base (list %containerized-shepherd-service))))
>
> Why not rewrite this using just a call to append, that is remove the
> call to cons? Like so:
No, IIRC ‘system-service-type’ should be the first in the list (?), but
also I find it more pleasant to the eye than an unbalanced ‘append’
call. :-)
Thanks for your feedback, I’ve pushed it now:
69cae3d335 system: Add 'essential-services' field to <operating-system>.
cf848cc0a1 accounts: Add default value for the 'home-directory' field of
<user-account>.
abd4d6b33d records: Allow thunked fields to refer to 'this-record'.
I hope that’ll help address your container use case!
Ludo’.