guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34879] [PATCH] gnu: yamagi-quake2: Update to 7.40.


From: nee
Subject: [bug#34879] [PATCH] gnu: yamagi-quake2: Update to 7.40.
Date: Mon, 1 Apr 2019 23:15:28 +0200

Hello, thank you for the review!

Am 16.03.19 um 06:09 schrieb Tobias Geerinckx-Rice:
> This version completely changes how it loads OpenAL.  The attached patch
> keeps everything working, but embeds an absolute store reference in the
> user's configuration file after the first run:>
>  λ grep /gnu/store ~/.yq2/baseq2/config.cfg  set al_driver
> "/gnu/store/…-openal-1.19.1/lib/libopenal.so.1"

Good job spotting that, how do you get it to generate that though? I
thought I didn't have it, because I had an old config, but now I moved
mine and it still doesn't appear.

Anyway, I looked at the code and curl seems to load the same way.

> 
> Any ideas, anyone?
> 
I think it's the best to just hard-code the path where it loads those
libraries. That prevents it from loading outdated or garbage collected
ones before the compiled one. Also curl doesn't have a default fallback
in the Makefile.

Try the new patch and do this to the config:
echo 'set al_driver "/tmp/non-existing-garbage-collected-library"' >>
~/.yq2/baseq2/config.cfg
echo 'set cl_libcurl "/tmp/non-existing-garbage-collected-library"' >>
~/.yq2/baseq2/config.cfg

I tested this new patch and the old patch, and the new one works while
the old one logs to stdout that failed to load curl and openal with that
config and falls back to sdl-audio.

Happy hacking!

Attachment: 0001-gnu-yamagi-quake2-Update-to-7.40.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]