[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35244] [PATCH 2/6] gnu: groff: Fix cross compilation.
From: |
Ludovic Courtès |
Subject: |
[bug#35244] [PATCH 2/6] gnu: groff: Fix cross compilation. |
Date: |
Sun, 14 Apr 2019 17:22:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi,
Mathieu Othacehe <address@hidden> skribis:
> * gnu/packages/groff.scm (groff)[arguments]: Replace build phase to pass
> GROFF_BIN_PATH and GROFFBIN variables when cross-compiling.
>
> Also add native groff as an input.
You’d need to mention ‘self-native-input?’ explicitly.
> + (self-native-input? #t)
However, this field no longer exists: see commit
a7646bc5e17a829d23519d0b199a576fb1edbd04, and see
528ea990c3a815cb4b0ded913ea22cdc778839bd for how to adjust your package.
> + (replace 'build
> + (lambda* (#:key
> + make-flags parallel-build?
> + native-inputs target #:allow-other-keys)
> + ;; When cross-compiling, native groff is needed, see:
> + ;; http://www.mail-archive.com/address@hidden/msg01335.html
> + (let ((parallel
> + (if parallel-build?
> + `("-j" ,(number->string (parallel-job-count)))
> + '()))
> + (flags
> + (if target
> + (let ((groff (or
> + (assoc-ref native-inputs "groff")
> + (assoc-ref native-inputs "self"))))
> + (append
> + make-flags
> + (list
> + (string-append "GROFF_BIN_PATH=" groff)
> + (string-append "GROFFBIN=" groff
> + "/bin/groff"))))
> + make-flags)))
> + (apply invoke `("make" ,@parallel ,@flags)))
If you make it conditional on (%current-target-system) , that’ll avoid a
massive rebuild of the 4K packages that depend on ‘groff’, and thus
it’ll be applicable on ‘master’.
Could you send an updated patch?
Thanks,
Ludo’.
- [bug#35244] [PATCH 0/6] Fix some cross-compilation issues., Mathieu Othacehe, 2019/04/12
- [bug#35244] [PATCH 1/6] gnu: bash-completion: Fix cross-compilation., Mathieu Othacehe, 2019/04/12
- [bug#35244] [PATCH 2/6] gnu: groff: Fix cross compilation., Mathieu Othacehe, 2019/04/12
- [bug#35244] [PATCH 2/6] gnu: groff: Fix cross compilation.,
Ludovic Courtès <=
- [bug#35244] [PATCH 3/6] gnu: glibc-utf8-locales: Always use native package., Mathieu Othacehe, 2019/04/12
- [bug#35244] [PATCH 4/6] gnu: firmware: Fix cross compilation., Mathieu Othacehe, 2019/04/12
- [bug#35244] [PATCH 6/6] gnu: python: Fix cross compilation., Mathieu Othacehe, 2019/04/12
- [bug#35244] [PATCH 5/6] linux-initrd: Fix cross compilation., Mathieu Othacehe, 2019/04/12
- [bug#35244] [PATCH 1/6] gnu: bash-completion: Fix cross-compilation., Ludovic Courtès, 2019/04/14