[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35330] [PATCH] gnu: certbot: Add support for manual plugin.
From: |
Ludovic Courtès |
Subject: |
[bug#35330] [PATCH] gnu: certbot: Add support for manual plugin. |
Date: |
Wed, 24 Apr 2019 14:29:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hello,
Julien Lepiller <address@hidden> skribis:
> * gnu/services/certbot.scm (certificate-configuration): Add challenge,
> auth-hook and cleanup-hook fields.
> (certbot-command): Use them.
> * doc/guix.texi (Certificate Services): Document them.
Neat!
Nitpick:
- s/http/HTTP/
- two spaces after end-of-sentence period
- s/filename/file name/
> address@hidden @code{challenge} (default: @code{#f})
> +The challenge type that has to be run by certbot. If @code{#f} is specified,
> +default to the http challenge. If a value is specified, defaults to the
> +manual plugin (see @code{auth-hook} and @code{cleanup-hook}).
If there’s a stable URL to upstream documentation, perhaps you could
insert it here.
> address@hidden @code{auth-hook} (default: @code{#f})
Should it be called ‘authentication-hook’?
I’m definitely no expert, but I’d say go for it!
Thanks for working on it!
Ludo’.