guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35467] [PATCH] Update Emacs packages.


From: Brian Leung
Subject: [bug#35467] [PATCH] Update Emacs packages.
Date: Mon, 20 May 2019 17:28:58 +0200

Friendly ping.

On Tue, May 14, 2019 at 1:36 AM Brian Leung <address@hidden> wrote:
Hi Ricardo,

OK, it looks like emacs-avy received a version bump two days ago. I've modified the patches appropriately and rebased with Guix's latest master branch.

Best,
Brian

On Mon, May 6, 2019 at 8:25 PM Brian Leung <address@hidden> wrote:
Hi Ricardo,

OK, I've made your suggested changes.

For future reference, is it possible to edit a past commit message with git fixup? I know how to edit the actual contents of past commits using git fixup, but not their commit messages. For these two patches, I had to manually make new commits.

Best,
Brian

On Mon, May 6, 2019 at 7:02 PM Ricardo Wurmus <address@hidden> wrote:

Hi Brian,

> Thanks for your response. The release version of emacs-highlight-symbol
> prints an occurrence count in the echo area upon hovering over a symbol,
> which is annoying because it can drown out important messages from (say)
> eldoc; this PR <https://github.com/nschum/highlight-symbol.el/pull/31>,
> which is not included in the release version, fixes that. The last release
> version of emacs-avy was from January 2016, and there have since been
> slightly over 100 commits since then for various features and bug
> fixes.

I see.  It would be good to include this information as a comment so
that people looking at this in the future understand why it was done.

Please also change the commit message to state the actual version and
not just a prefix of the commit hash.  Please use the version string
that would be used by Guix (something like “1.2.3-1.cabbage”).

--
Ricardo

Attachment: 0001-gnu-emacs-highlight-symbol-Update-to-1.3.1-7a789c7.patch
Description: Text Data

Attachment: 0002-gnu-emacs-avy-Update-to-0.5.0.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]