[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35855] [PATCH] gnu: Add coq-stdpp.

From: Dan Frumin
Subject: [bug#35855] [PATCH] gnu: Add coq-stdpp.
Date: Fri, 24 May 2019 19:11:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

Hi Ludovic,

Thanks for looking over my patch!

On 24-05-19 18:23, Ludovic Courtès wrote:
Hi Dan,

I took the liberty to apply the minor changes below and applied the
patch (grep, diffutils, etc. are implicit inputs of ‘gnu-build-system’,
so you don’t need to list them;

Oh interesting. I recall that I had to add those programs explicitly as inputs as some point (otherwise I couldn't build it in `guix environment coq-stdpp`), but perhaps my memory is playing tricks on me.

as for ‘invoke’, it’s now the preferred
way to invoke programs.)

Oops, dunno why I missed that...

Thank you!


diff --git a/gnu/packages/coq.scm b/gnu/packages/coq.scm
index 15a7e791f9..6c48af4fc9 100644
--- a/gnu/packages/coq.scm
+++ b/gnu/packages/coq.scm
@@ -551,11 +551,6 @@ kernel.")
      (build-system gnu-build-system)
-    (native-inputs
-     `(("grep" ,grep)  ;; need egrep for tests
-       ("gawk" ,gawk)
-       ;; need diff for tests
-       ("diffutils" ,diffutils)))
       `(("coq" ,coq)))
@@ -566,10 +561,10 @@ kernel.")
           (replace 'install
             (lambda* (#:key outputs #:allow-other-keys)
               (setenv "COQLIB" (string-append (assoc-ref outputs "out") 
-             (zero? (system* "make"
-                             (string-append "COQLIB=" (assoc-ref outputs "out")
-                                            "/lib/coq/")
-                             "install")))))))
+             (invoke "make"
+                     (string-append "COQLIB=" (assoc-ref outputs "out")
+                                    "/lib/coq/")
+                     "install"))))))
      (description "This project contains an extended \"Standard Library\" for
  Coq called coq-std++.  The key features are:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]