[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35922] [PATCH] gnu: add terminator

From: Andy Tai
Subject: [bug#35922] [PATCH] gnu: add terminator
Date: Wed, 29 May 2019 22:58:03 -0700

On Wed, May 29, 2019 at 2:10 PM Ludovic Courtès <address@hidden> wrote:

address@hidden skribis:

> From: Andy Tai <address@hidden>
> * gnu/packages/gnome.scm (terminator): Add at 1.91


> +    (arguments
> +     `(#:python ,python-2))

Python 2.x is reaching EOL real soon.  Can it run on Python 3?

hi, no, not the current upstream... I tried with python-3 and won't run

> +    (description
> +     "A tool to allow running multiple GNOME terminals in a grid and
> +     tabs and support for drag and drop re-ordering of terminals")

Could you make a full sentence and remove the trailing spaces?  See

will update
> +    (license license:gpl2)))

This means “version 2 only”.  Is there an explicit “version 2 only”
statement, for example in source file headers?  If not, it should be

source clearly labeled gpl "Version 2 Only" 
Could you send an updated patch?

will do 
Thank you,

Andy Tai, address@hidden, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2019 民國108年

reply via email to

[Prev in Thread] Current Thread [Next in Thread]