[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36011: [PATCH 1/2] gnu: gnucash: Update to 3.5.
|
From: |
Kei Kebreau |
|
Subject: |
bug#36011: [PATCH 1/2] gnu: gnucash: Update to 3.5. |
|
Date: |
Fri, 31 May 2019 23:07:44 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hi Vasile,
The patch looks good overall, but the way the commit log is written is a
bit off. It's mostly good though, so I've committed the patch myself
with the changes mentioned below.
Vasile Dumitrascu <address@hidden> writes:
> * gnu/packages/gnucash.scm (gnucash): Update to 3.5.
> [source]: Remove uneeded patch.
> * gnu/local.mk: Remove delete patch.
The value modified within gnu/local.mk should be specified. In this
case, the line would look line this:
"* gnu/local.mk (dist_patch_DATA): Remove patch."
Also, mention that you actually deleted the obsolete patch:
"* gnu/packages/patches/gnucash-fix-test-transaction-failure.patch: Delete
file."
Thanks for contributing!