guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#36011] [PATCH 1/2] gnu: gnucash: Update to 3.5.


From: Dumitrascu Vasile
Subject: [bug#36011] [PATCH 1/2] gnu: gnucash: Update to 3.5.
Date: Sat, 1 Jun 2019 11:28:13 +0000 (UTC)

  Hi Kei

Thank you for the corrections and the merge,

  Vasile


On Saturday, June 1, 2019, 5:07:51 AM GMT+2, Kei Kebreau <address@hidden> wrote:


Hi Vasile,

The patch looks good overall, but the way the commit log is written is a
bit off. It's mostly good though, so I've committed the patch myself
with the changes mentioned below.

Vasile Dumitrascu <address@hidden> writes:

> * gnu/packages/gnucash.scm (gnucash): Update to 3.5.
> [source]: Remove uneeded patch.
> * gnu/local.mk: Remove delete patch.


The value modified within gnu/local.mk should be specified. In this
case, the line would look line this:
"* gnu/local.mk (dist_patch_DATA): Remove patch."

Also, mention that you actually deleted the obsolete patch:
"* gnu/packages/patches/gnucash-fix-test-transaction-failure.patch: Delete file."

Thanks for contributing!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]