[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36404] [PATCH 4/4] doc: Add section for 'guix deploy'.
From: |
Kyle Meyer |
Subject: |
[bug#36404] [PATCH 4/4] doc: Add section for 'guix deploy'. |
Date: |
Tue, 02 Jul 2019 00:16:38 -0400 |
Hi Jakob,
Thanks for working on this and for all the effort you've put into
sharing your progress with the list. It's been interesting to watch
from the sidelines. I don't know enough to say anything useful about
the code changes, but here are a few minor comments about the guix.texi
changes.
address@hidden (Jakob L. Kreuze) writes:
[...]
> +The file should evaluate to a list of @var{machine} objects. This example,
> +upon being deployed, will create a new generation on the remote system
> +realizing the operating-system configuration @var{%system}. @var{environment}
> +and @var{configuration} specify how the machine should be provisioned--that
nitpick: Following the style used elsewhere in guix.texi, I think this
"--" and the closing one below should be "---" with no surrounding
spaces.
> +is, deployment and management of computing resources. The above example does
> +not provision any resources -- a @code{'managed-host} is a machine that is
> +already up and running the Guix system. A more complex deployment may involve
> +i.e. starting virtual machines through a VPS provider, however, in which case
> +a different @var{environment} types would be used.
This last sentence doesn't quite parse for me. Perhaps
A more complex deployment may involve, for example, starting virtual
machines through a VPS provider. In such as case, a different
@var{environment} type would be used.
?
[...]
> +@item @code{environment}
> +A symbol describing how the machine should be provisioned. At the moment,
> only
> +the only supported value is @code{'managed-host}.
Repeated "only".
Also, as a meta nit: It'd be helpful if you'd mark updated patch series
with the iteration count (e.g., v3). You can do this with
git-format-patch's --reroll-count option.
--
Kyle
- [bug#36404] [PATCH 1/3] guix system: Add 'reconfigure' module., (continued)
- [bug#36404] [PATCH 1/3] guix system: Add 'reconfigure' module., Ludovic Courtès, 2019/07/06
- [bug#36404] [PATCH 0/3] Refactor out common behavior for system reconfiguration., Ludovic Courtès, 2019/07/06
- [bug#36404] [PATCH 0/3] Refactor out common behavior for system reconfiguration., Christopher Lemmer Webber, 2019/07/07
- [bug#36404] [PATCH 0/3] Refactor out common behavior for system reconfiguration., Ludovic Courtès, 2019/07/07
- [bug#36404] [PATCH 0/3] Refactor out common behavior for system reconfiguration., Jakob L. Kreuze, 2019/07/08
[bug#36404] [PATCH 0/4] Add 'guix deploy'., Jakob L. Kreuze, 2019/07/01
- [bug#36404] [PATCH 1/4] ssh: Add 'identity' keyword to 'open-ssh-session'., Jakob L. Kreuze, 2019/07/01
- [bug#36404] [PATCH 2/4] gnu: Add machine type for deployment specifications., Jakob L. Kreuze, 2019/07/01
- [bug#36404] [PATCH 3/4] Add 'guix deploy'., Jakob L. Kreuze, 2019/07/01
- [bug#36404] [PATCH 4/4] doc: Add section for 'guix deploy'., Jakob L. Kreuze, 2019/07/01
- [bug#36404] [PATCH 4/4] doc: Add section for 'guix deploy'.,
Kyle Meyer <=
- [bug#36404] [PATCH 4/4] doc: Add section for 'guix deploy'., Jakob L. Kreuze, 2019/07/02
- [bug#36404] [PATCH 4/4] doc: Add section for 'guix deploy'., Kyle Meyer, 2019/07/02
- [bug#36404] [PATCH v4 0/4] Add 'guix deploy'., Jakob L. Kreuze, 2019/07/02
- [bug#36404] [PATCH v4 1/4] ssh: Add 'identity' keyword to 'open-ssh-session'., Jakob L. Kreuze, 2019/07/02
- [bug#36404] [PATCH v4 2/4] gnu: Add machine type for deployment specifications., Jakob L. Kreuze, 2019/07/02
- [bug#36404] [PATCH v4 3/4] Add 'guix deploy'., Jakob L. Kreuze, 2019/07/02
- [bug#36404] [PATCH v4 4/4] doc: Add section for 'guix deploy'., Jakob L. Kreuze, 2019/07/02
- [bug#36404] [PATCH v4 4/4] doc: Add section for 'guix deploy'., Christopher Lemmer Webber, 2019/07/03
- [bug#36404] [PATCH v4 4/4] doc: Add section for 'guix deploy'., Ludovic Courtès, 2019/07/04
[bug#36404] [PATCH v4 4/4] doc: Add section for 'guix deploy'., Thompson, David, 2019/07/04