guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#35388] [PATCH] gnu: julia: Update to 1.1.0


From: Nicolò Balzarotti
Subject: [bug#35388] [PATCH] gnu: julia: Update to 1.1.0
Date: Sun, 21 Jul 2019 10:43:01 +0000

Hello guix!
After the longest week ever, I'm back. I had to power off my build server because is a bit noisy, and building llvm on a laptop is slow.

Finally, I upgraded julia to 1.1.1 (even if 1.2 is already at rc2).

I know inline patches are preferred but I don't have access to my email client right now.

@Ludvic, as you asked, I placed the llvm-patches in an "origin" field, with 2 small helpers functions used to generate the url and the field.

Let me know if this is better, hopefully julia will find its way into guix :)

Many many thanks, and sorry again for the late response,

Nicolò

Il giorno lun 27 mag 2019 alle ore 20:06 Nicolò Balzarotti <address@hidden> ha scritto:
Hi, thanks for the bump.

Sure but in the meanwhile they upgraded to 1.1.1 .-.

I promise I'll have a look again this week ;)

Nicolò

Il giorno lun 27 mag 2019 alle ore 14:27 Ludovic Courtès <address@hidden> ha scritto:
Hi Nicolò,

Did you have a chance to look into it?

Thanks,
Ludo’.

Ludovic Courtès <address@hidden> skribis:

> Hi Nicolò,
>
> Nicolò Balzarotti <address@hidden> skribis:
>
>> One second problem regards the llvm patches. They should be generic (as stated
>> in the link in the patch, [2]) but are actually needed to compile julia (so I
>> cannot use pure system llvm, but I don't feel like applying them to system
>> llvm all by myself).
>
> OK.
>
>> The .patch files are available in the julia source package: is it ok to place them in the patches folder or shuld I fetch the julia source and extract them during build?
>
> It would be best if they could be downloaded from upstream.  For that
> you could use one ‘origin’ for each patch and use them directly in the
> ‘patches’ field.  Alternately, if that’s more convenient, you could add
> one ‘origin’ for the whole repository, and add an ‘apply-patches’ to the
> ‘llvm-julia’ package that would pick patches in the right place.
>
> Could you also try to provide a commit log listing all the changes that
> this patch makes?  You can read ‘git log’ for examples or see
> <https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>.
>
> Other than that I think it should be ready to go, and I’m really happy a
> newer Julia package is around the corner!
>
> Thank you, and apologies for the delay!
>
> Ludo’.

Attachment: 0001-gnu-julia-Update-to-1.1.1.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]