[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36477] [PATCH v3 06/48] gnu: groff: Fix cross compilation.
From: |
Ludovic Courtès |
Subject: |
[bug#36477] [PATCH v3 06/48] gnu: groff: Fix cross compilation. |
Date: |
Wed, 04 Sep 2019 15:23:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Mathieu Othacehe <address@hidden> skribis:
> * gnu/packages/groff.scm (groff)[arguments]: Replace build phase to pass
> GROFF_BIN_PATH and GROFFBIN variables when cross-compiling.
>
> Also add native groff as a native-input when cross-compiling.
Please mention changes to ‘groff-minimal’.
[...]
> + ,@(if (%current-target-system)
> + '((replace 'build
> + (lambda* (#:key
> + make-flags parallel-build?
> + native-inputs target #:allow-other-keys)
> + ;; When cross-compiling, native groff is needed, see:
> + ;; http://www.mail-archive.com/address@hidden/msg01335.html
> + (let ((parallel
> + (if parallel-build?
> + `("-j" ,(number->string (parallel-job-count)))
> + '()))
> + (flags
> + (if target
> + (let ((groff (or
> + (assoc-ref native-inputs "groff")
> + (assoc-ref native-inputs "self"))))
> + (append
> + make-flags
> + (list
> + (string-append "GROFF_BIN_PATH=" groff)
> + (string-append "GROFFBIN=" groff
> + "/bin/groff"))))
> + make-flags)))
Wouldn’t it be easier to have:
(arguments
`(,@(if (%current-target-system)
`(#:make-flags (list (string-append "GROFF_BIN_PATH="
(assoc-ref %build-native-inputs
"self)
…)))
'()
…))
?
> (native-inputs `(("bison" ,bison)
> - ("perl" ,perl)))
> + ("perl" ,perl)
> + ("groff" ,groff)))
Should probably be:
("self" ,this-package)
for consistency.
Thanks,
Ludo’.
- [bug#36477] [PATCH v3 03/48] gnu: texinfo: Fix cross-compilation., (continued)
[bug#36477] [PATCH v3 05/48] gnu: libpaper: Fix aarch64 cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 09/48] gnu: indent: Fix aarch64 cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 10/48] gnu: libsamplerate: Fix aarch64 cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 12/48] gnu: mkfontdir: Fix aarch64 cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 02/48] gnu: openssl: Fix cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 07/48] gnu: texinfo-5: Fix cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 06/48] gnu: groff: Fix cross compilation., Mathieu Othacehe, 2019/09/02
- [bug#36477] [PATCH v3 06/48] gnu: groff: Fix cross compilation.,
Ludovic Courtès <=
[bug#36477] [PATCH v3 04/48] gnu: cmake: Fix cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 14/48] gnu: glibc-utf8-locales: Fix cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 11/48] gnu: cyrus-sasl: Fix cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 13/48] gnu: icu4c: Fix cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 16/48] gnu: eudev: Fix cross-compilation., Mathieu Othacehe, 2019/09/02
[bug#36477] [PATCH v3 19/48] gnu: bdb: Fix cross-compilation., Mathieu Othacehe, 2019/09/02