[bug#37642] [PATCH] gnu: Add filters

[Jesse Gibbons]

On Wed, 2019-10-09 at 22:40 -0600, Jesse Gibbons wrote:
> On Wed, 2019-10-09 at 15:14 +0200, Tobias Geerinckx-Rice wrote:
> > Jesse,
> > 
> > Jesse Gibbons 写道：
> > > That review was a bit of a mess. Let's see if I can rephrase 
> > > what you want,
> > > in a human-friendly format (no emacs involved):
> > 
> > Yes, I'm so sorry.  It looked fine while writing; I'm not actually 
> > on crack.
> emacs might have been.
> 
> > > Use a patch instead or move this to the source's snippet so 
> > > kenny is removed
> > > from the raw source.
> > 
> > A patch would contain a ‘negative’ verbatim copy of the non-free 
> > code so isn't an option here.
> > 
> Moved it to source's snippet.
> > > > +         #:tests? #f))
> > > clarify we have no tests suite
> > 
> > Yep.  Ideally that comment would be redundant because we'd never 
> > flat-out disable tests in packages that have them, but we do.
> > 
> rednotebook's test suite is disabled because it fails, but the program
> itself works fine. There's a TODO note there to fix the tests.
> 
> Added comment.
> 
> > > > +The GNU project hosts a similar collection of filters, the GNU
> > > > talkfilters.  Due
> > > > +to copyright concerns and difficulty in communication between
> > > > maintainers, these
> > > > +collections have not been merged.")
> > > You want me to remove this.
> > > I think it's appropriate to say something about gnu talkfilters 
> > > and note
> > > that this is not the same package, given that filters and 
> > > talkfilters
> > > packages are often confused with each other on the internet,
> > 
> > OK.  I didn't know they were often confused.  Would it make sense 
> > to add it to GNU's, too?
> > 
> > > but I will remove the last sentence.
> > 
> > Great.  It's the one that bothered me.
> > 
> Sentence removed
> > >  If the comments go beyond 80 characters I will move the 
> > >  comments above the license.
> > 
> > For such whole-line comments you *would* use ‘;;’, start with a 
> > capital letter, and end with a full stop…
> > 
> I was able to fit the comments after a line.
> > > Am I missing anything?
> - Cleaned up package descriptions. Only one takes up more than a line now,
> and they focus more on behavior.
> - Changed "80's" to "1980's"
> - Fixed various typos
> 
> New patch is attached.
> > Kind regards,
> > 
> > T G-R
bump