[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue

From: Danny Milosavljevic
Subject: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue
Date: Tue, 7 Jan 2020 10:52:14 +0100

Hi Reza,

thanks for the patch.  I think that it is the right way for now.

But GIO_LAUNCH_DESKTOP is not interpreted as a list by glib.

It would be better to communicate intent by constructing GIO_LAUNCH_DESKTOP as

               (wrap-program (string-append out "/bin/pcmanfm-qt")
                 `("GIO_LAUNCH_DESKTOP" =
                   (,(string-append glib "/bin/gio-launch-desktop"))))


Otherwise, with ":" and "prefix" it very much sounded like a list.

Also, could you make it check whether /bin/gio-launch-desktop exists and
error out otherwise?  That is in order for us to notice the workaround
later when we move the gio-launch-desktop executable.

(if (file-exists? ".........../bin/gio-launch-desktop")
    (wrap-program ........)
    (error "Could not find gio-launch-desktop"))

Attachment: pgpsTF2Su4MPh.pgp
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]