[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38846: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit acces
From: |
Ludovic Courtès |
Subject: |
bug#38846: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. |
Date: |
Thu, 09 Jan 2020 23:39:16 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Tobias Geerinckx-Rice <address@hidden> skribis:
> Ludovic Courtès 写道:
>> +@item
>> +Send @email{guix-maintainers@@gnu.org} a signed message stating
>> your
>> +intent, listing the three committers who support your application,
>> and
>> +giving the fingerprint of the OpenPGP key you will use to sign
>> commits
>> +(see below).
>> +
>> +@item
>> +Once you've been given access, please send a message to
> ^^^^
>
> Probably just me, but this glosses over maintainer approval just a bit
> too deftly, and that even with 3 signed referrals commit access isn't
> guaranteed, just extremely likely.
>
> Unless that will actually change, I think we should briefly mention it
> as well. People react worse to ‘let's try again later’ when they
> think they've already passed. Understandably so.
Good points (from Maxim, too).
>> +@email{guix-devel@@gnu.org} to say so, again signed with the
>> OpenPGP key
>> +you will use to sign commits. That way, everyone can notice and
>> ensure
>> +you control that OpenPGP key.
>
> Best to add an explicit ‘before pushing your first commit’ here, if
> that is the intent.
Indeed.
>> +When you get commit access, please make sure to follow
> ^^^^
>
> ‘If’? Same point as the first @items above.
Yes.
I’ve now pushed the whole series:
ef09cb866c doc: Add a cooptation policy for commit access.
98ebcf1c1b doc: Encourage patch review.
2d315cd428 doc: Move "Commit Access" section from 'HACKING' to the manual.
a7bde77d24 doc: Add "Tracking Bugs and Patches" section.
I believe I’ve taken into account all the changes that were proposed.
If you think anything still needs to be adjusted, let’s do that.
Thanks everyone!
Ludo’.
- [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access., (continued)
- [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access., Brett Gilio, 2020/01/01
- [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access., Ricardo Wurmus, 2020/01/02
- [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access., Ludovic Courtès, 2020/01/02
- [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access., Tobias Geerinckx-Rice, 2020/01/06
- [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access., Tobias Geerinckx-Rice, 2020/01/06
- [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access., Brett Gilio, 2020/01/06
- [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access., zimoun, 2020/01/07
- bug#38846: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access.,
Ludovic Courtès <=
[bug#38846] [PATCH 3/4] doc: Encourage patch review., Ludovic Courtès, 2020/01/01
[bug#38846] [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section., Ricardo Wurmus, 2020/01/01
[bug#38846] [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section., zimoun, 2020/01/01
[bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access, Ricardo Wurmus, 2020/01/01
[bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access, Ludovic Courtès, 2020/01/06
[bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access, zimoun, 2020/01/06