[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39146] [PATCH v2] gnu: icecat: Remove about:buildconfig store refer
From: |
Tobias Geerinckx-Rice |
Subject: |
[bug#39146] [PATCH v2] gnu: icecat: Remove about:buildconfig store references. |
Date: |
Wed, 22 Jan 2020 21:13:13 +0100 |
* gnu/packages/gnuzilla.scm (icecat)[arguments]:
New ‘neutralise-store-references’ phase.
Reported-by: Jakub Kądziołka <address@hidden>
---
So,
Here's a version that correctly calls %store-directory. Tested again, output
looks the same.
Jakub: I accidentally kept your copyright line in v1, but didn't actually use
your code (although part of your comment survives :-). Is the Reported-by
above acceptable?
Kind regards,
T G-R
gnu/packages/gnuzilla.scm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index ae0c58eedb..96c3c78e98 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -7,7 +7,7 @@
;;; Copyright © 2016 Alex Griffin <address@hidden>
;;; Copyright © 2017 Clément Lassieur <address@hidden>
;;; Copyright © 2017 ng0 <address@hidden>
-;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <address@hidden>
+;;; Copyright © 2017, 2018, 2020 Tobias Geerinckx-Rice <address@hidden>
;;; Copyright © 2018 Ricardo Wurmus <address@hidden>
;;; Copyright © 2019 Ivan Petkov <address@hidden>
;;; Copyright © 2020 Oleg Pykhalov <address@hidden>
@@ -1067,6 +1067,15 @@ from forcing GEXP-PROMISE."
(force-output)
(retry (- remaining-attempts 1))))
(apply build args)))))))
+ (add-after 'build 'neutralise-store-references
+ (lambda _
+ ;; Mangle the store references to compilers & other build tools in
+ ;; about:buildconfig, reducing IceCat's closure by 1 GiB on
x86-64.
+ (substitute*
+ "dist/bin/chrome/toolkit/content/global/buildconfig.html"
+ (((format #f "(~a/)([0-9a-z]{32})" (%store-directory)) _ store
hash)
+ (string-append store (string-take hash 8) "…")))
+ #t))
(add-before 'configure 'install-desktop-entry
(lambda* (#:key outputs #:allow-other-keys)
;; Install the '.desktop' file.
--
2.23.0
[bug#39146] [PATCH] gnu: icecat: Remove about:buildconfig store references., Tobias Geerinckx-Rice, 2020/01/21
[bug#39146] [PATCH v2] gnu: icecat: Remove about:buildconfig store references.,
Tobias Geerinckx-Rice <=