[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#39384] [PATCH] gnu: Add emacs-rg.

From: Nicolas Goaziou
Subject: [bug#39384] [PATCH] gnu: Add emacs-rg.
Date: Sat, 01 Feb 2020 23:09:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)


"LaFreniere, Joseph" <address@hidden> writes:

> Patch file is attached to package

Thank you! Some comments follow.

> +       (sha256
> +        (base32
> +         "0k7x5z7mh9flwih35cqy8chs54rack3nswdcpw5wcpgv6xim227y"))))

Nitpick: I think the trend is to align `base32' with the string.

> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-s" ,emacs-s)
> +       ("emacs-wgrep" ,emacs-wgrep)
> +       ("ripgrep" ,ripgrep)))
> +    (home-page "";)
> +    (synopsis "A search tool based on @code{ripgrep}")

You may want to lint your package. In particular, the synopsis should be
akin to "Search tool based ..."

> +    (description
> +     "An Emacs search package based on the @code{ripgrep} command line

The description must start with a full sentence, e.g., "rg.el" is an
Emacs search package...

> +tool. It allows you to interactively create searches, doing automatic 
> searches

Texinfo requires two spaces after the full stop.

> +based on the editing context, refining and modifying search results and much
> +more. It is also highly configurable to be able to fit different users’

Ditto. Besides, the quote after "users" looks suspicious. You should use
a regular quote.

Could you send an updated patch?


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]