[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#39261] [PATCH] guix: import/crate: Move build-dependencies to cargo

From: Efraim Flashner
Subject: [bug#39261] [PATCH] guix: import/crate: Move build-dependencies to cargo-inputs.
Date: Wed, 05 Feb 2020 07:14:04 +0000
User-agent: K-9 Mail for Android

I'm actually going to let this one ride until we review the importer patches. 
Then if it still makes sense we can apply this one.

On February 4, 2020 11:17:36 PM UTC, "Ludovic Courtès" <address@hidden> wrote:
>Nitpick: for the subject line, I’d write:
>  import: crate: Move build dependencies to cargo-inputs.
>Efraim Flashner <address@hidden> skribis:
>> * guix/import/crate.scm (crate->guix-package): Add definition for
>> 'dev-dependency?' and 'build-dependency?'. Adjust dep-crates to take
>> normal- and build- dependencies.
>> +  (define (dev-dependency? dependency)
>> +    (eq? (crate-dependency-kind dependency) 'dev))
>Nitpick2: I’d recommend ‘development-dependency?’ as per the style
>guidelines.  :-)
>Anyhow, LGTM!

Sent from my Android device with K-9 Mail. Please excuse my brevity.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]