[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#38546] [00/11] Update Julia, Fix precompilation, add HTTP.jl

From: Nicolò Balzarotti
Subject: [bug#38546] [00/11] Update Julia, Fix precompilation, add HTTP.jl
Date: Tue, 11 Feb 2020 16:10:17 +0100

zimoun <address@hidden> writes:

> Hi Nicoló,
> I have seen your message on IRC.
> Cool for the release 1.4.
> Could we try to include first this 1.3 one?  Then push the 1.4 if it
> is already ready.
> Because then, this release will be usable "forever" (or almost ;-)
> even if it is not perfect and issues are fixed with the 1.4.
> I mean, once a package is inside Guix, then it becomes "easily" usable
> with 'guix time-machine' and saved on Software Heritage.
> Therefore, considering the big picture of Scientific Reproducibility,
> it matters -- for the future to be able to travel back -- to also have
> 1.3. ;-)

Ok, let's do both
> I think we are almost done. From my point of view, we just need to
> address (or comment) these 3 points:
> 1.
>> Do you have a special motivation to rename 'llvm-patch' to 'julia-patch'?
>> (I agree, it is better :-))
Yes, because now it's not only used by llvm-julia but also by the new
libunwind-julia.  So calling llvm-patch a function that takes a patch
from the julia repo and that is applied to a "julia module" is measleading.

> 2.
>> Well, only 2 inputs are missing. Do you think it is affordable to pack
>> them and so remove the commentary?
>> --8<---------------cut here---------------start------------->8---
>> ;; FIXME: The following inputs are downloaded from upstream to allow us
>> ;; to use the lightweight Julia release tarball.  Ideally, these inputs
>> ;; would eventually be replaced with proper Guix packages.
>> ;; Find dependencies versions here:
>> ;; 
>> --8<---------------cut here---------------end--------------->8---

I indeed tried.  The main problem is that in the Makefile there's no
USE_SYSTEM_{OBJCONV/LIBWHICH}, and I didn't want to mess with the it.
But yes, I think I could at least try again.

> 3.
>> Otherwise, there is some issues about indentation -- I think you use
>> Emacs, so check that '.dir-locals.el' is correctly setup -- double
>> space for sentences in description,
>> 'patch/julia-SOURCE_DATE_EPOCH-mtime.patch' should be added with the
>> same commit that "Update", etc.
>> I have half-corrected so I can send you these 2 v2-patches if you want to. 
>> :-)
If you already fixed them, yes please send a v2 patch and I'll continue
working from there.

> What do you think?
Fine for me, do we need also to debug a broken test right?
> Cheers,
> simon


reply via email to

[Prev in Thread] Current Thread [Next in Thread]