[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39619: [v2] Re: bug#39619: Acknowledgement ([PATCH 0/4] Add nheko ma
From: |
Nicolas Goaziou |
Subject: |
bug#39619: [v2] Re: bug#39619: Acknowledgement ([PATCH 0/4] Add nheko matrix client) |
Date: |
Sun, 23 Feb 2020 00:48:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Nicolò Balzarotti <address@hidden> writes:
> lmdbxx was patch #3, but I created some noise sending replying to
> guix-patches and creating multiple issues. I'm sending it again with
> other fixes applied.
OK. I applied your patches with the two small changes below:
> + (add-before 'configure 'disable-network-tests
> + (lambda _
> + (substitute* "CMakeLists.txt"
> +
> (("add_test\\([BasicConnectivity|ClientAPI|MediaAPI|Encryption]")
> + "# add_test"))
I changed the regexp to:
"add_test\\((BasicConnectivity|ClientAPI|MediaAPI|Encryption)"
instead.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/drycpp/lmdbxx.git")
> + (commit (string-append version))))
I removed the `string-append' call.
I also added copyright lines for you in "cpp.scm" and "databases.scm".
Thank you!
Regards,
--
Nicolas Goaziou