[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40035] Add widelands game
From: |
Nicolas Goaziou |
Subject: |
[bug#40035] Add widelands game |
Date: |
Fri, 13 Mar 2020 09:16:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Alberto EFG <address@hidden> writes:
> I added all the changes. The synopsis is slightly different than
> requested, because of character length.
Thanks!
> +(define-public widelands
> + (package
> + (name "widelands")
> + (version "20")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> "https://launchpad.net/widelands/build20/build20/+download/"
> + name "-build" version ".tar.bz2"))
I suggest to use version everywhere in the `uri' string:
(string-append "https://launchpad.net/widelands/build" version "/build"
version "/" ...)
> + (description
> + "Widelands is a strategy game aiming for gameplay similar to Settlers
> II by
> + BlueByte.
> +
> + In this game, you start out on a small piece of land with nothing more
> than
> + a few of useful resources. Using those, you can build yourself an empire
> + with many thousands of inhabitants. On your way towards this goal, you
> will
> + have to build up an economic infrastructure, explore the lands around you
> + and face enemies who are trying to rule the world just like you do.")
The description should not be indented.
> + (license (list
> + license:gpl2+
> + license:gpl3+
> + license:expat
> + license:zlib
> + license:silofl1.1
> + license:asl2.0
> + license:cc-by-sa3.0))))
I suggest to add a comment explaining that the software, as a whole, is
gpl2+, but assets are released under various licenses.
BTW, the source ships with "minizip" and "gettext" in "src/third_party".
Could you try unbundling them and use the ones provided by Guix?
Otherwise, LGTM!
Regards,
--
Nicolas Goaziou