[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages
From: |
Felix Gruber |
Subject: |
[bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages |
Date: |
Fri, 13 Mar 2020 18:26:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi Ludo’,
On 3/13/20 10:42 AM, Ludovic Courtès wrote:
> Felix Gruber <address@hidden> skribis:
>
>> * gnu/packages/maths.scm (dune-*-openmpi): New variables.
>> * gnu/packages/maths.scm (add-openmpi-to-dune-package): New function to
>> add openmpi to the inputs of a dune-* package and replace all dune-*
>> packages in its input with the corresponding dune-*-openmpi package.
>
> Nitpick: no need to repeat the file name above. It would also be great
> if you could list all the new variables.
Sure, no problem.
>> + (lambda (p) (not (dune-package? p))))))
>
> You can replace the lambda with:
>
> (negate dune-package?)
Thanks for this hint, as I'm new to Scheme, my knowledge of its standard
library is still pretty limited. The negate function is quite useful.
> One last thing: could you look at the output of, say, ‘guix graph
> dune-geometry-openmpi’ and ensure we’re not duplicating more nodes than
> needed in the graph?
>
> For example, you can compare node counts with:
>
> guix graph dune-geometry | grep 'label =' | wc -l
> guix graph dune-geometry-openmpi | grep 'label =' | wc -l
>
> The difference should be less than:
>
> guix graph openmpi | grep 'label =' | wc -l
>
> If that works well, please send an updated patch and we should be ready
> to go!
I get the following numbers:
graph dune-geometry | grep 'label =' | wc -l
70
guix graph dune-geometry-openmpi | grep 'label =' | wc -l
143
guix graph openmpi | grep 'label =' | wc -l
137
The difference seems to be OK: 143 - 70 = 73 < 137.
I'll send the updated patch ASAP.
Best Regards,
Felix
- [bug#39862] [PATCH v2 0/6] Update Dune finite element packages, (continued)
- [bug#39862] [PATCH v2 4/6] gnu: dune-istl: Build with suitesparse, Felix Gruber, 2020/03/10
- [bug#39862] [PATCH v2 5/6] gnu: dune-*: remove openmpi dependency, Felix Gruber, 2020/03/10
- [bug#39862] [PATCH v2 6/6] gnu: define dune-*-openmpi packages, Felix Gruber, 2020/03/10
- [bug#39862] [PATCH v2 6/6] gnu: define dune-*-openmpi packages, Ludovic Courtès, 2020/03/12
- [bug#39862] [PATCH v3 0/2] Add dune-*-openmpi packages, Felix Gruber, 2020/03/12
- [bug#39862] [PATCH v3 1/2] gnu: dune-*: remove openmpi dependency, Felix Gruber, 2020/03/12
- [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages, Felix Gruber, 2020/03/12
- [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages, Ludovic Courtès, 2020/03/13
- [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages,
Felix Gruber <=
- [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages, Ludovic Courtès, 2020/03/13
- [bug#39862] [PATCH v4 2/2] gnu: define dune-*-openmpi packages, Felix Gruber, 2020/03/13
- [bug#39862] [PATCH v4 1/2] gnu: dune-*: remove openmpi dependency, Felix Gruber, 2020/03/13
- bug#39862: [PATCH v4 1/2] gnu: dune-*: remove openmpi dependency, Ludovic Courtès, 2020/03/14