[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40221] Submission of GUI Package Description for 7kaa
From: |
Nicolas Goaziou |
Subject: |
[bug#40221] Submission of GUI Package Description for 7kaa |
Date: |
Wed, 25 Mar 2020 15:00:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Naga Malleswari <address@hidden> writes:
> Hence i added to games.scm(assuming thats the actual location. Please
> correct me) and done with the patch.
Thank you!
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/the3dfxdude/7kaa/archive/v"
> + version ".tar.gz"))
This URL is not stable. Home page provides a stable release at:
https://github.com/the3dfxdude/7kaa/releases/download/v2.15.3/7kaa-2.15.3.tar.xz
I suggest to use this one, replacing 2.5.13 with `version', like you did.
> + (sha256
> + (base32 "0bf90v1bm4zazwalfl9vd5dfbdcxwhi02rmggn5xc0yq0zkxwlqv"))))
> + (build-system gnu-build-system)
> + (native-inputs
> + `(("automake" ,automake)
> + ("autoconf" ,autoconf)
> + ("pkg-config" ,pkg-config)))
Could you re-order inputs alphabetically?
> + (inputs
> + `(("sdl2" ,sdl2)
> + ("enet" ,enet)
> + ("openal" ,openal)
> + ("gettext" ,gettext-minimal)
> + ("curl" ,curl)))
Ditto.
> + (home-page "https://7kfans.com/")
> + (synopsis "Seven Kingdoms Ancient Adversaries: real-time strategy game")
> + (description
> + "Seven Kingdoms, designed by Trevor Chan, brings a unique blend of
> +Real-Time Strategy with the addition of trade, diplomacy, and espionage.
We try to avoid adding "marketing" words or idioms in descriptions, like
"unique blend". I think "blend" is enough.
> +7kfans project is updating the game and
> +provides a community for fans. A free Seven Kingdoms will help continue
> +the legacy.")
I suggest to drop this part, which is not informative in the
description. Besides, everything is Free in Guix.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou